Skip to content

CosmosDB PITR restorable resources dotnet sdk#17595

Merged
nisha-bhatia merged 3 commits intoAzure:masterfrom
vinhms:cosmosdb-restorable-dotnet-sdk
Dec 30, 2020
Merged

CosmosDB PITR restorable resources dotnet sdk#17595
nisha-bhatia merged 3 commits intoAzure:masterfrom
vinhms:cosmosdb-restorable-dotnet-sdk

Conversation

@vinhms
Copy link
Copy Markdown
Contributor

@vinhms vinhms commented Dec 16, 2020 

    Adding new APIs for Point in Time Restore feature
      Adding ApiType and RestorableLocations information in the response of the existing Restorable Database Account APIs
      Introducing new Restorable APIs for SQL and MongoDB for the following:
        - Get a list of all databases for a given SQL or MongoDB account
        - Get a list of all collections/containers for a specific database
        - Get a list of database/collection resources for a given region and timestamp
      We provide these new APIs to help user find the corresponding events and timestamp before they perform the restore.

@vinhms
Copy link
Copy Markdown
Contributor Author

vinhms commented Dec 16, 2020

@kavskalyan @MehaKaushik please review this PR

MehaKaushik
MehaKaushik reviewed Dec 18, 2020
View reviewed changes
Comment thread ...soft.Azure.Management.CosmosDB/src/Generated/Models/DatabaseAccountCreateUpdateProperties.cs
/// <summary>
/// Properties to create and update Azure Cosmos DB database accounts.
/// </summary>
[Newtonsoft.Json.JsonObject("DatabaseAccountCreateUpdateProperties")]
Copy link
Copy Markdown
Contributor

@MehaKaushik MehaKaushik Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this got removed. It may have to do with the autorest version used to generate the package.

Copy link
Copy Markdown
Contributor

@MehaKaushik MehaKaushik Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the command you used to generate the package ?

Copy link
Copy Markdown
Contributor

@MehaKaushik MehaKaushik Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note this is not a blocking comment if you cant find the reason to this change,, feel free to ignore it.

Copy link
Copy Markdown
Contributor Author

@vinhms vinhms Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure what that got removed..

this is the autorest command that i used:
autorest.cmd "C:\code\swagger\azure-rest-api-specs\specification\cosmos-db\resource-manager\readme.md" --csharp --version=v2 --reflect-api-versions --csharp-sdks-folder=C:\code\sdk\azure-sdk-for-net\sdk

MehaKaushik
MehaKaushik reviewed Dec 18, 2020
View reviewed changes
Comment thread ...crosoft.Azure.Management.CosmosDB/src/Generated/Models/RestorableMongodbDatabaseGetResult.cs
/// <param name="type">The type of Azure resource.</param>
/// <param name="location">The location of the resource group to which
/// the resource belongs.</param>
public RestorableMongodbDatabaseGetResult(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), ManagedServiceIdentity identity = default(ManagedServiceIdentity), RestorableMongodbDatabasePropertiesResource resource = default(RestorableMongodbDatabasePropertiesResource))
Copy link
Copy Markdown
Contributor

@MehaKaushik MehaKaushik Dec 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinhms can you please check if this is true? i.e. at our service side do we have each of location, tags and ManagedServiceIdentity for RestorableMongodbDatabaseGetResult.
If not, then we should fix this in swagger.

MehaKaushik
MehaKaushik approved these changes Dec 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@MehaKaushik MehaKaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, looks good otherwise.

@nisha-bhatia
Copy link
Copy Markdown
Contributor

nisha-bhatia commented Dec 23, 2020

@vinhms Could you please provide Swagger link?

@vinhms
Copy link
Copy Markdown
Contributor Author

vinhms commented Dec 28, 2020 •
edited
Loading

@vinhms Could you please provide Swagger link?

@nisha-bhatia here's the swagger: Azure/azure-rest-api-specs#11428

@nisha-bhatia nisha-bhatia merged commit 9096473 into Azure:master Dec 30, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
@vinhms @annelo-msft
CosmosDB PITR restorable resources dotnet sdk (Azure#17595)
ae35e47 
* add restorable tests

* bump version

* change version to 1.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@bquantump bquantump Awaiting requested review from bquantump

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@danieljurek danieljurek Awaiting requested review from danieljurek

@m-nash m-nash Awaiting requested review from m-nash

@markcowl markcowl Awaiting requested review from markcowl

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@nisha-bhatia nisha-bhatia Awaiting requested review from nisha-bhatia

@weshaggard weshaggard Awaiting requested review from weshaggard

@YalinLi0312 YalinLi0312 Awaiting requested review from YalinLi0312

1 more reviewer

@MehaKaushik MehaKaushik MehaKaushik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nisha-bhatia nisha-bhatia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vinhms @nisha-bhatia @MehaKaushik